Skip to content

Commit

Permalink
Bring back ASInitializeFrameworkMainThread so we don't break the API (#…
Browse files Browse the repository at this point in the history
…2050)

In PR 2032 we added alloc/dealloc texture initialization methods for the case where texture is automatically initializing. However, in doing so we have removed the `ASInitializeFrameworkMainThread` method that clients may already be using.

This PR brings back the `ASInitializeFrameworkMainThread` to live side by side with `ASInitializeFrameworkMainThreadOnConstructor` and `ASInitializeFrameworkMainThreadOnDestructor`. This should keep the old functionality in place for any client using `ASInitializeFrameworkMainThread` directly.
  • Loading branch information
rcancro committed Dec 6, 2021
1 parent 053688b commit 50426db
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
4 changes: 4 additions & 0 deletions Source/Private/ASInternalHelpers.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ NS_ASSUME_NONNULL_BEGIN
ASDK_EXTERN void ASInitializeFrameworkMainThreadOnConstructor(void);
ASDK_EXTERN void ASInitializeFrameworkMainThreadOnDestructor(void);

// Calls both ASInitializeFrameworkMainThreadOnConstructor and ASInitializeFrameworkMainThreadOnDestructor
// Used when manually initializing texture
ASDK_EXTERN void ASInitializeFrameworkMainThread(void);

ASDK_EXTERN BOOL ASDefaultAllowsGroupOpacity(void);
ASDK_EXTERN BOOL ASDefaultAllowsEdgeAntialiasing(void);

Expand Down
6 changes: 6 additions & 0 deletions Source/Private/ASInternalHelpers.mm
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,12 @@ void ASInitializeFrameworkMainThreadOnDestructor(void)
});
}

ASDK_EXTERN void ASInitializeFrameworkMainThread(void)
{
ASInitializeFrameworkMainThreadOnConstructor();
ASInitializeFrameworkMainThreadOnDestructor();
}

BOOL ASSubclassOverridesSelector(Class superclass, Class subclass, SEL selector)
{
if (superclass == subclass) return NO; // Even if the class implements the selector, it doesn't override itself.
Expand Down

0 comments on commit 50426db

Please sign in to comment.