Replace +load initializers with __attribute__((constructor)) functions (

#1425) * Replace +load initializers with __attribute__((constructor)) functions * Updating the documentation for textureDidInitialize, per @nguyenhuy
TextureGroup · Mar 29, 2019 · 69f42db · 69f42db
1 parent 5f8161e
commit 69f42db
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Source/ASConfigurationDelegate.h b/Source/ASConfigurationDelegate.h
@@ -27,8 +27,8 @@ NS_ASSUME_NONNULL_BEGIN
 /**
  * Texture framework initialized. This method is called synchronously
  * on the main thread from ASInitializeFrameworkMainThread if you defined
- * AS_INITIALIZE_FRAMEWORK_MANUALLY or from the default initialization point
- * (currently +load) otherwise.
+ * AS_INITIALIZE_FRAMEWORK_MANUALLY or otherwise from the default initialization point
+ * (currently a static constructor, called before main()).
  */
 - (void)textureDidInitialize;
 

diff --git a/Source/ASDisplayNode.mm b/Source/ASDisplayNode.mm
@@ -284,7 +284,7 @@ + (void)initialize
 }
 
 #if !AS_INITIALIZE_FRAMEWORK_MANUALLY
-+ (void)load
+__attribute__((constructor)) static void ASLoadFrameworkInitializer(void)
 {
   ASInitializeFrameworkMainThread();
 }

diff --git a/Source/Private/ASTipsController.mm b/Source/Private/ASTipsController.mm
@@ -37,9 +37,9 @@ @implementation ASTipsController
 
 #pragma mark - Singleton
 
-+ (void)load
+__attribute__((constructor)) static void ASLoadTipsControllerNotification(void)
 {
-  [NSNotificationCenter.defaultCenter addObserver:self.shared
+  [NSNotificationCenter.defaultCenter addObserver:ASTipsController.shared
                                          selector:@selector(windowDidBecomeVisibleWithNotification:)
                                              name:UIWindowDidBecomeVisibleNotification
                                            object:nil];