NoCopyRendering experiment: Fix possible memory leak if image node re…

…ndering is canceled #trivial (#765) * Fix memory leak if image node rendering is canceled * Update comment
TextureGroup · Jan 23, 2018 · 6b94b94 · 6b94b94
1 parent 2e98588
commit 6b94b94
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/Source/ASImageNode.mm b/Source/ASImageNode.mm
@@ -522,10 +522,9 @@ + (UIImage *)createContentsForkey:(ASImageNodeContentsKey *)key drawParameters:(
     key.didDisplayNodeContentWithRenderingContext(context, drawParameters);
   }
 
-  // The following `UIGraphicsGetImageFromCurrentImageContext` call will commonly take more than 20ms on an
-  // A5 processor.  Check for cancellation before we call it.
+  // Check cancellation one last time before forming image.
   if (isCancelled()) {
-    UIGraphicsEndImageContext();
+    ASGraphicsEndImageContext();
     return nil;
   }
 

diff --git a/Source/Details/ASGraphicsContext.h b/Source/Details/ASGraphicsContext.h
@@ -23,6 +23,9 @@
  *
  * The API mirrors the UIGraphics API, with the exception that forming an image
  * ends the context as well.
+ *
+ * Note: You must not mix-and-match between ASGraphics* and UIGraphics* functions
+ * within the same drawing operation.
  */
 
 NS_ASSUME_NONNULL_BEGIN