-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
add ASTextNode2 snapshot test (#935)
* fix SIMULATE_WEB_RESPONSE not imported #449 * Fix to make rangeMode update in right time * remove uncessary assert * textnode2-snapshot-test * add change log * fix image recording * disable recording * renaming test method * reset experiment in teardown
- Loading branch information
1 parent
ee06e97
commit 9fe2f47
Showing
9 changed files
with
156 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,150 @@ | ||
// | ||
// ASTextNode2SnapshotTests.mm | ||
// Texture | ||
// | ||
// Copyright (c) 2017-present, Pinterest, Inc. All rights reserved. | ||
// Licensed under the Apache License, Version 2.0 (the "License"); | ||
// you may not use this file except in compliance with the License. | ||
// You may obtain a copy of the License at | ||
// | ||
// http://www.apache.org/licenses/LICENSE-2.0 | ||
// | ||
|
||
|
||
#import "ASTestCase.h" | ||
#import "ASSnapshotTestCase.h" | ||
#import <AsyncDisplayKit/AsyncDisplayKit.h> | ||
|
||
@interface ASTextNode2SnapshotTests : ASSnapshotTestCase | ||
|
||
@end | ||
|
||
@implementation ASTextNode2SnapshotTests | ||
|
||
- (void)setUp | ||
{ | ||
[super setUp]; | ||
|
||
// This will use ASTextNode2 for snapshot tests. | ||
// All tests are duplicated from ASTextNodeSnapshotTests. | ||
ASConfiguration *config = [[ASConfiguration alloc] initWithDictionary:nil]; | ||
config.experimentalFeatures = ASExperimentalTextNode; | ||
[ASConfigurationManager test_resetWithConfiguration:config]; | ||
|
||
self.recordMode = NO; | ||
} | ||
|
||
- (void)tearDown | ||
{ | ||
[super tearDown]; | ||
ASConfiguration *config = [[ASConfiguration alloc] initWithDictionary:nil]; | ||
config.experimentalFeatures = kNilOptions; | ||
[ASConfigurationManager test_resetWithConfiguration:config]; | ||
} | ||
|
||
- (void)testTextContainerInset_ASTextNode2 | ||
{ | ||
// trivial test case to ensure ASSnapshotTestCase works | ||
ASTextNode *textNode = [[ASTextNode alloc] init]; | ||
textNode.attributedText = [[NSAttributedString alloc] initWithString:@"judar" | ||
attributes:@{NSFontAttributeName : [UIFont italicSystemFontOfSize:24]}]; | ||
textNode.textContainerInset = UIEdgeInsetsMake(0, 2, 0, 2); | ||
ASDisplayNodeSizeToFitSizeRange(textNode, ASSizeRangeMake(CGSizeZero, CGSizeMake(CGFLOAT_MAX, CGFLOAT_MAX))); | ||
|
||
ASSnapshotVerifyNode(textNode, nil); | ||
} | ||
|
||
- (void)testTextContainerInsetIsIncludedWithSmallerConstrainedSize_ASTextNode2 | ||
{ | ||
UIView *backgroundView = [[UIView alloc] initWithFrame:CGRectZero]; | ||
backgroundView.layer.as_allowsHighlightDrawing = YES; | ||
|
||
ASTextNode *textNode = [[ASTextNode alloc] init]; | ||
textNode.attributedText = [[NSAttributedString alloc] initWithString:@"judar judar judar judar judar judar" | ||
attributes:@{ NSFontAttributeName : [UIFont systemFontOfSize:30] }]; | ||
|
||
textNode.textContainerInset = UIEdgeInsetsMake(10, 10, 10, 10); | ||
|
||
ASLayout *layout = [textNode layoutThatFits:ASSizeRangeMake(CGSizeZero, CGSizeMake(100, 80))]; | ||
textNode.frame = CGRectMake(50, 50, layout.size.width, layout.size.height); | ||
|
||
[backgroundView addSubview:textNode.view]; | ||
backgroundView.frame = UIEdgeInsetsInsetRect(textNode.bounds, UIEdgeInsetsMake(-50, -50, -50, -50)); | ||
|
||
textNode.highlightRange = NSMakeRange(0, textNode.attributedText.length); | ||
|
||
[ASSnapshotTestCase hackilySynchronouslyRecursivelyRenderNode:textNode]; | ||
ASSnapshotVerifyLayer(backgroundView.layer, nil); | ||
} | ||
|
||
- (void)testTextContainerInsetHighlight_ASTextNode2 | ||
{ | ||
UIView *backgroundView = [[UIView alloc] initWithFrame:CGRectZero]; | ||
backgroundView.layer.as_allowsHighlightDrawing = YES; | ||
|
||
ASTextNode *textNode = [[ASTextNode alloc] init]; | ||
textNode.attributedText = [[NSAttributedString alloc] initWithString:@"yolo" | ||
attributes:@{ NSFontAttributeName : [UIFont systemFontOfSize:30] }]; | ||
|
||
textNode.textContainerInset = UIEdgeInsetsMake(5, 10, 10, 5); | ||
ASLayout *layout = [textNode layoutThatFits:ASSizeRangeMake(CGSizeZero, CGSizeMake(INFINITY, INFINITY))]; | ||
textNode.frame = CGRectMake(50, 50, layout.size.width, layout.size.height); | ||
|
||
[backgroundView addSubview:textNode.view]; | ||
backgroundView.frame = UIEdgeInsetsInsetRect(textNode.bounds, UIEdgeInsetsMake(-50, -50, -50, -50)); | ||
|
||
textNode.highlightRange = NSMakeRange(0, textNode.attributedText.length); | ||
|
||
[ASSnapshotTestCase hackilySynchronouslyRecursivelyRenderNode:textNode]; | ||
ASSnapshotVerifyView(backgroundView, nil); | ||
} | ||
|
||
// This test is disabled because the fast-path is disabled. | ||
- (void)DISABLED_testThatFastPathTruncationWorks_ASTextNode2 | ||
{ | ||
ASTextNode *textNode = [[ASTextNode alloc] init]; | ||
textNode.attributedText = [[NSAttributedString alloc] initWithString:@"Quality is Important" attributes:@{ NSForegroundColorAttributeName: [UIColor blueColor], NSFontAttributeName: [UIFont italicSystemFontOfSize:24] }]; | ||
[textNode layoutThatFits:ASSizeRangeMake(CGSizeZero, CGSizeMake(100, 50))]; | ||
ASSnapshotVerifyNode(textNode, nil); | ||
} | ||
|
||
- (void)testThatSlowPathTruncationWorks_ASTextNode2 | ||
{ | ||
ASTextNode *textNode = [[ASTextNode alloc] init]; | ||
textNode.attributedText = [[NSAttributedString alloc] initWithString:@"Quality is Important" attributes:@{ NSForegroundColorAttributeName: [UIColor blueColor], NSFontAttributeName: [UIFont italicSystemFontOfSize:24] }]; | ||
// Set exclusion paths to trigger slow path | ||
textNode.exclusionPaths = @[ [UIBezierPath bezierPath] ]; | ||
ASDisplayNodeSizeToFitSizeRange(textNode, ASSizeRangeMake(CGSizeZero, CGSizeMake(100, 50))); | ||
ASSnapshotVerifyNode(textNode, nil); | ||
} | ||
|
||
- (void)testShadowing_ASTextNode2 | ||
{ | ||
ASTextNode *textNode = [[ASTextNode alloc] init]; | ||
textNode.attributedText = [[NSAttributedString alloc] initWithString:@"Quality is Important"]; | ||
textNode.shadowColor = [UIColor blackColor].CGColor; | ||
textNode.shadowOpacity = 0.3; | ||
textNode.shadowRadius = 3; | ||
textNode.shadowOffset = CGSizeMake(0, 1); | ||
ASDisplayNodeSizeToFitSizeRange(textNode, ASSizeRangeMake(CGSizeZero, CGSizeMake(INFINITY, INFINITY))); | ||
ASSnapshotVerifyNode(textNode, nil); | ||
} | ||
|
||
/** | ||
* https://github.com/TextureGroup/Texture/issues/822 | ||
*/ | ||
- (void)DISABLED_testThatTruncationTokenAttributesPrecedeThoseInheritedFromTextWhenTruncateTailMode_ASTextNode2 | ||
{ | ||
ASTextNode *textNode = [[ASTextNode alloc] init]; | ||
textNode.style.maxSize = CGSizeMake(20, 80); | ||
NSMutableAttributedString *mas = [[NSMutableAttributedString alloc] initWithString:@"Quality is an important "]; | ||
[mas appendAttributedString:[[NSAttributedString alloc] initWithString:@"thing" attributes:@{ NSBackgroundColorAttributeName : UIColor.yellowColor}]]; | ||
textNode.attributedText = mas; | ||
textNode.truncationMode = NSLineBreakByTruncatingTail; | ||
|
||
textNode.truncationAttributedText = [[NSAttributedString alloc] initWithString:@"\u2026" attributes:@{ NSBackgroundColorAttributeName: UIColor.greenColor }]; | ||
ASDisplayNodeSizeToFitSizeRange(textNode, ASSizeRangeMake(CGSizeZero, CGSizeMake(INFINITY, INFINITY))); | ||
ASSnapshotVerifyNode(textNode, nil); | ||
} | ||
|
||
@end |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+4.29 KB
...s/testTextContainerInsetIsIncludedWithSmallerConstrainedSize_ASTextNode2@2x.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added
BIN
+2.61 KB
...s/ReferenceImages_iOS_10/ASTextNodeSnapshotTests/[email protected]
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.