-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ASEditableTextNode contents not accessible to VoiceOver #1135
Comments
@ay8s Hey, did you find something out yet? Thanks! |
For now I ended up updating the accessibility value with the text from the textView in editableTextNodeDidUpdateText: Also digging into a few other reports. Curious if Pinterest has any issues at all with ASEditableTextNode accessibility? Seems odd it's not free as a wrapper around UITextView. |
Digging into this one some more, there are pretty drastic differences in what VoiceOver reads between ASEditableTextNode and UITextView. In this example I simply put a ASEditableTextNode (green) at the top and a UITextView (red) below. Both are within a ASViewController with the UITextView wrapped in a ASDisplayNode. No other settings were changed for either the ASEditableTextNode or the UITextView.
When inputting characters...
Will continue to dig in, now sure if there may be something conflicting with the expected VO output. Video: https://cl.ly/49c21c61cd58 |
Digging in more to this today after exploring just using UITextView. Seems that if I use ASDK_ACCESSIBILITY_DISABLE it works correctly. Oddly ASViewController's that use ASEditableTextNode as the root node work fine, only when a ASEditableTextNode is included as a subnode default behavior is lost. |
@maicki @nguyenhuy So I think I've figured out the cause. When a ASEditableTextNode is a root node its textView is available via "view". This isn't the case when it is a subnode. When we're collecting the accessibility elements here we're not looking for the textView. Texture/Source/Details/_ASDisplayViewAccessiblity.mm Lines 215 to 234 in 465abb1
I quickly hacked together adding the textView to the elements array and VoiceOver returned the correct information back to the user. Any downsides you can see adding the following? I'm sure there may be a better more elegant solution.
|
Could we set isAccessibilityElement to YES on init in ASEditableTextNode? Then it would add subside.view which is the textView in this case? |
@garrettmoon When I try that VoiceOver simply reads "Actions available". |
Closing |
Just had a report of this, it looks like the contents typed into an ASEditableTextNode aren't accessible when using VoiceOver. Will try and dig in tomorrow and see if I can do a pull request.
The text was updated successfully, but these errors were encountered: