Make ASEditableTextNode accessible to VoiceOver

[ay8s]

Should resolve issues seen in #1135 where VoiceOver is unable to access the text view and correctly read out the value while inputting text.

[maicki]

@ay8s Could we try implement the accessibility methods within ASEditableTextNode:

// Return 1 here for the textView
- (NSInteger)accessibilityElementCount
{
  return 1;
}

- (id)accessibilityElementAtIndex:(NSInteger)index
{
  return self.textView;
}

- (NSInteger)indexOfAccessibilityElement:(id)element
{
  return 1;
}

Not sure if this is the right approach yet, but we would make the ASEditableTextNode an accessibility container with this.

[ay8s]

@maicki Tried a couple of approaches with this.

Making the ASEditableTextNode a container with isAccessibilityElement true, doesn't get it picked up as we don't collect the UIAccessibilityElements for non layerBacked nodes and only add the subnodes view to the array.

With isAccessibilityElement set to false we get the same outcome where only the subnodes view is added to the array.

https://github.com/TextureGroup/Texture/blob/master/Source/Details/_ASDisplayViewAccessiblity.mm#L215-L234

[maicki]

If this lands: #1188 we may can just return the textView within -[ASEditableTextNode accessibilityElements] ASEditableTextNode and therefore avoid having to check explicitly in _ASDisplayViewAccessiblity. cc @ay8s

[maicki]

@ay8s #1188 just landed on master. Could you pull latest and check if my suggestion above would work? Thanks!

[ay8s]

On it @maicki

[ay8s]

Working now @maicki. 👍

[maicki]

@ay8s Thanks again for working on this. After the requested change let's get it in and sorry for the late response.

[maicki]

@ay8s Thanks for working on this!