Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ASEditableTextNode accessible to VoiceOver #1162

Merged
merged 13 commits into from
Nov 10, 2018
Merged

Make ASEditableTextNode accessible to VoiceOver #1162

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
a66e4af
Make ASEditableTextNode accessible to VoiceOver
ay8s Oct 4, 2018
882b470
Update CHANGELOG
ay8s Oct 4, 2018
8f67450
Merge branch 'master' into task/editableTextNodeAccessibilityFix
ay8s Oct 18, 2018
a027a5f
Make ASEditableTextNode an accessibility container
ay8s Oct 18, 2018
b22a461
Merge branch 'master' of https://github.com/TextureGroup/Texture into…
ay8s Oct 30, 2018
efa6607
Remove initial fix
ay8s Oct 30, 2018
05af317
Changelog
ay8s Oct 30, 2018
d6778c2
Correct changelog entry
ay8s Oct 30, 2018
e2eb5ef
Remove isAccessibilityElement as it’s a container
ay8s Oct 31, 2018
b12a801
Merge branch 'master' into task/editableTextNodeAccessibilityFix
Adlai-Holler Nov 4, 2018
9d0800f
Merge branch 'master' of https://github.com/TextureGroup/Texture into…
ay8s Nov 9, 2018
cfcbdf6
Add isNodeLoaded checks
ay8s Nov 9, 2018
371ea20
Remove Changelog Changes
ay8s Nov 9, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -622,4 +622,4 @@



\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
ay8s marked this conversation as resolved.
Show resolved Hide resolved
\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
20 changes: 20 additions & 0 deletions Source/ASEditableTextNode.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -842,4 +842,24 @@ - (void)_delegateDidFinishEditing
[_delegate editableTextNodeDidFinishEditing:self];
}

ay8s marked this conversation as resolved.
Show resolved Hide resolved
- (NSInteger)accessibilityElementCount
{
return 1;
}

- (NSArray *)accessibilityElements
ay8s marked this conversation as resolved.
Show resolved Hide resolved
{
return @[self.textView];
}

- (id)accessibilityElementAtIndex:(NSInteger)index
{
return self.textView;
}

- (NSInteger)indexOfAccessibilityElement:(id)element
{
return 0;
}

@end