Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] ASResponderChainEnumerator threading requirement #342

Open
nguyenhuy opened this issue Jun 8, 2017 · 3 comments
Open

[RFC] ASResponderChainEnumerator threading requirement #342

nguyenhuy opened this issue Jun 8, 2017 · 3 comments
Assignees

Comments

@nguyenhuy
Copy link
Member

As reported in #341, ASResponderChainEnumerator can sometimes be initiated off the main thread, which seems to be expected base on the comment here. However, a couple of main thread assertions were added recently here.

I think ideally we should remove the assertions if we know -[UIResponder nextResponder] is thread-safe, and the new Main Thread Checker might give us the answer. Otherwise, we sadly have to avoid printing the view controller if it's off main.

@Adlai-Holler
Copy link
Member

Unfortunately -[UIView nextResponder] is implemented as [self superview] which is main-thread only, so responder chain traversing is main-thread-only. I think #348 should make things tolerable.

@Adlai-Holler
Copy link
Member

@nguyenhuy Feel absolutely free to reopen this but I believe #348 gives us as much flexibility as safely possible.

@nguyenhuy
Copy link
Member Author

nguyenhuy commented Sep 26, 2017

@Adlai-Holler So I'm hitting this complaint from the Main Thread checker while running our test suite :(

screen shot 2017-09-26 at 4 24 41 pm

nguyenhuy added a commit to nguyenhuy/Texture that referenced this issue Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants