Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: rename -[ASCellNode nodeViewModel] to nodeModel #501

Closed
mlilek-nyt opened this issue Aug 8, 2017 · 1 comment
Closed

Proposal: rename -[ASCellNode nodeViewModel] to nodeModel #501

mlilek-nyt opened this issue Aug 8, 2017 · 1 comment

Comments

@mlilek-nyt
Copy link

#499 renamed ASCellNode's viewModel property to nodeViewModel to avoid collisions with view model implementations on top of the framework.

It was brought up on slack that "view" terminology should be avoided to not cause confusion with the node's view property.

I'm proposing renaming this again to nodeModel. You have a ViewModel on a View, it seems reasonable for folks to understand on a Node you have a NodeModel.

Thoughts?
@nguyenhuy
Copy link
Member

Renamed to nodeModel in #504. Thanks for opening up the discussion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nguyenhuy @mlilek-nyt