Rename the field again to nodeModel #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
requested review from
appleguy,
maicki,
garrettmoon and
nguyenhuy
Kaspik
suggested changes
Aug 10, 2017
| @@ -326,7 +326,7 @@ - (void)performUpdateReloadingSections:(NSDictionary<NSNumber *, id> *)reloadedS | |||
| }]; | |||
|
|
|||
| for (NSIndexPath *indexPath in [insertsPlusReloads.allKeys sortedArrayUsingSelector:@selector(compare:)]) { | |||
| [self expectViewModelMethodForItemAtIndexPath:indexPath viewModel:insertsPlusReloads[indexPath]]; | |||
| [self expectnodeModelMethodForItemAtIndexPath:indexPath nodeModel:insertsPlusReloads[indexPath]]; | |||
There was a problem hiding this comment.
expectnodeModelMethodForItemAtIndexPath -> expectNodeModelMethodForItemAtIndexPath
maicki
approved these changes
Aug 10, 2017
Adlai-Holler
added a commit
that referenced
this pull request
Aug 15, 2017
bernieperez
pushed a commit
to AtomTickets/Texture
that referenced
this pull request
Apr 25, 2018
* Rename the field to nodeModel * A few more instances * Fix method name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a somewhat larger followup to #499, because that diff kept the terminology "view model" but added the prefix "node" to indicate that it's the view model as far as ASDisplayNode is concerned.
This diff changes the terminology itself to "node model," which is much more suited.