Rewrite Swift Example #1002
Merged
Rewrite Swift Example #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
maicki
commented
Jul 1, 2018
maicki
commented
- Switch to Unsplash API
- Use new 4.x features like Codable
- Cleanup code
- We should think of moving this example back into the normal examples folder
nguyenhuy
requested changes
Jul 3, 2018
| @@ -0,0 +1,610 @@ | |||
| /// A generic collection for storing key-value pairs in an ordered manner. | |||
There was a problem hiding this comment.
I think we need to include copyright and license notices of the original author here.
There was a problem hiding this comment.
Yep I will change that, but also ask him if he can merge in the Cocoapods PR they have open so we can just pull it in via that. That said I changed some stuff around to improve the runtime of checking if a key is in the dictionary that I will try to get in the main repo before.
maicki
force-pushed
the
MSRewriteSwiftExample
branch
from
ea0ee60
to
725e821
Compare
|
@nguyenhuy Just added the license header to |
Generated by 🚫 Danger |
nguyenhuy
approved these changes
Jul 5, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
* Rewrite Swift Example * Add license header to OrderedDictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.