-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IGListKit] Extended IGListKit support for displaying delegates #1011
Merged
bolsinga
merged 128 commits into
TextureGroup:master
from
hebertialmeida:HAImproveIGListSupport
May 21, 2020
Merged
Changes from 9 commits
Commits
Show all changes
128 commits
Select commit
Hold shift + click to select a range
3a007fc
Extended IGListKit support for node deselect, highlight and unhighlight
hebertialmeida 755a1eb
Proposal of renaming willDisplayItemWithNode and didEndDisplayingItem…
hebertialmeida c1699c4
Extended support for IGListDisplayDelegate
hebertialmeida fc94d8e
Updated changelog with displaying delegates change
hebertialmeida 822f16d
Removed extra deprecation supression flag
hebertialmeida 37398c0
Reverted ASCollectionNode changes and implemented displaing delegate …
hebertialmeida 7905d1e
Sending a real UICollectionViewCell to the delegate if not nil
hebertialmeida d941a03
Added safety check for nil indexPaths
hebertialmeida 6ee40ba
Merge branch 'master' into HAImproveIGListSupport
hebertialmeida 4657343
Merge branch 'master' into HAImproveIGListSupport
hebertialmeida 05e2ce2
Discard any CHANGELOG changes for fix Danger error
hebertialmeida 0078f5f
Merge branch 'master' into HAImproveIGListSupport
hebertialmeida ac08bb8
Add an experimental flag to use native dispatch_apply (#1345)
Adlai-Holler 2fbc452
Don't return non-animated GIFs for animation (update to latest PINRem…
garrettmoon 37e5955
Fix typos (#1348)
c284847
Revert "Have node and controller share lock (#1227)" (#1347)
Adlai-Holler 60ee8d4
Don't compile out ASExperimentalTextNode if ASTextNode is compiled ou…
maicki 71eb5a3
Lock up to yogaRoot during layout to avoid deadlocks. (#1356)
wiseoldduck 72d4d79
Update layout-transition-api.md (#1357)
dirtmelon 877b6cd
Optimize ASTwoDimensionalArrayUtils (#1351)
Adlai-Holler 378e0d2
If we check for batching before content size is available we'll alway…
garrettmoon 49dd925
Do not lock the nodeController if we are not locking to root. (#1360)
wiseoldduck fd223d0
Resolve root constrained size before informing delegate to resolve in…
wiseoldduck f3c2ad7
Add `setNeedsLayout` to yoga tree changes. (#1361)
wiseoldduck d4a1754
Make ASCollectionElement Public (#1303)
JonathanDowning 03746f0
Optimize _assertSubnodeState (#1352)
Adlai-Holler e20c651
_ASCollectionViewCell - The point isn't converted before to send to n…
Idefix60 954382d
Optimize ASCATransactionQueue (#1350)
Adlai-Holler e498969
Cleanup Yoga Categories (#1364)
maicki abf0212
Add forwarding of UIAccessibilityAction methods (#1344)
smeis f7182c7
Don't add extraneous truncation token during kCTLineTruncationMiddle.…
wiseoldduck 88dd4a2
Update the FAQ to throw less shade. (#1379)
garrettmoon 1a2e397
[Updated Snapshots] Don't add extraneous truncation token during kCTL…
wiseoldduck 9d633d5
Launches switching ASNetworkImageNode callbacks to global queue. (#1369)
garrettmoon 5b1e14c
Make ASTextNode2 more forgiving when searching for links (#1374)
Adlai-Holler 0547eaa
Experiment with different strategies for image downloader priority (#…
nguyenhuy 54ddc3d
Whoops, someone forgot an else! (#1385)
garrettmoon 4a16e99
Catch invalid sizes during yoga layout (#1376)
wiseoldduck 5827e97
Correct View vs. Layer here (tho it doesn't make any difference) (#1378)
wiseoldduck 2c0dfda
Expose initial constrained size before layout in case anyone is inter…
wiseoldduck 975cd37
Assert for context creation failure during displayBlock. (#1373)
wiseoldduck 46e2a81
Fix an issue where state change notifications can be sent mulitple ti…
wiseoldduck 17f9b00
Add Yoga support to ASButtonNode (#1381)
maicki f17b9e2
Fix CTLineRef leaks (#1386)
bolsinga 932289f
Correct attributes lookup for supplementary elements. (#1318)
wiseoldduck b20e007
Need some more locks for working with calculated yoga layouts (#1388)
wiseoldduck 19e7bc3
Adds support for using UIGraphicsImageRenderer in ASTextNode. (#1384)
garrettmoon 36d14ac
Add UIDataSourceModelAssociation to ASTableView and ASCollectionView …
farktronix fbddcd4
Rename ASDN C++ namespace to AS (#1366)
Adlai-Holler a1768e2
Clean up a clang analyzer cast error (#1387)
bolsinga f67f968
Update for 9.4.1 CI (#1392)
garrettmoon fb5820a
Remove experimental features (exp_skip_a11y_wait && exp_new_default_c…
ernestmama ad53898
Make experiment checks faster (#1393)
Adlai-Holler 79323c1
Make shared CA transaction queue variable extern so it's actually sha…
Adlai-Holler d5339ac
Fix header typo (#1402)
Adlai-Holler 902131a
Context is a pretty general name that will cause conflicts with subcl…
garrettmoon 88291f2
Suppress documentation warnings when using external libraries (#1401)
bolsinga 45d9050
Add layer-action support to nodes (#1396)
Adlai-Holler 602a1b2
Avoid an unnecessary lock & unlock pair in ASMainSerialQueue (#1409)
nguyenhuy ad0d4d6
Add clang-format for a common source code format (#1365)
maicki 44846e8
Fix GIF Caching (#1405)
ay8s 1bbddab
Add support for reverse direction to yoga layouts (#1413)
wiseoldduck 66532c6
Only set ASLayoutElementStyle delegate if Yoga is enabled (#1417)
maicki 4766a0b
Fix bug in ASRangeController that causes some cell nodes of a collect…
nguyenhuy 30600cb
Fix a bug with Yoga nodes whose position change and don't update. (#1…
tnorman42 3415d1b
Follow up on the ASRangeController fix in #1418 (#1419)
nguyenhuy c340fff
Dev docs for threading in Texture (#1319)
mikezucc 6aaf0dc
Removed locked jekyll version (#1322)
mikezucc d34a182
showcase.md updated (#1421)
plotkin b6a6b0f
Experiment with disabling ASViewController background dealloc (#1420)
mikezucc a631803
[Experiment] Dont forget about these collection view background deall…
mikezucc 6b81f5a
Fix retain cycle with transaction operations (#1429)
bolsinga 7d105ec
Replace +load initializers with __attribute__((constructor)) function…
farktronix 2234c47
Fix dealloc on bg (#1410)
wsdwsd0829 c47d6d5
Add support for clipping only specific corners, add unit tests (#1415)
Adlai-Holler fb1a586
[ASImageNode]fix incorrect backing size calculation (#1189)
junjielu 976fd43
Have image nodes draw into opaque contexts automatically if possible …
Adlai-Holler c345733
Fix typo in batch-fetching-api.md (#1437)
dirtmelon 0143c9f
[ASDisplayNode] Stop infinite layout in _u_measureNodeWithBoundsIfNec…
rcancro ef10f42
Add a verbose log for locking operations. Has no effect in production…
Adlai-Holler 026eb1d
Wrap transaction operation retain cycle fix in an experiment (#1438)
bolsinga da3d4a2
Fix scroll node in yoga (#1435)
wsdwsd0829 14c1b76
Fix the stub for layerActionForKey: to let CA continue the search (#1…
Adlai-Holler 9fed474
Revert "Have image nodes draw into opaque contexts automatically if p…
Adlai-Holler 0a94eb0
Use instance lock for ASPrimitiveTraitCollection (#1442)
maicki 7930476
Simplify ASTraitCollection propagation in ASViewController (#1447)
maicki 4ec9ac6
Use AS::Mutex in ASCollectionElement (#1445)
maicki 8dea604
[ASTextNode] Maintain isAccessibilityElement setting on text nodes wh…
smeis 377aeeb
Add didEnterHierarchy/didExitHierarchy to ASNodeController. (#1444)
tnorman42 70b1161
Fix wrongly formatted RELEASE link (#1453)
BalestraPatrick 5e98f46
Only create activities during debug (#1456)
Adlai-Holler 3ca9f0c
[#1451] Add support for UIAccessibilityCustomAction (#1452)
shamanskyh dcd9905
Shut down graphics contexts experiment (#1458)
Adlai-Holler 429891d
Remove lock of ASTextNodeRendererKey (#1454)
zhongwuzw 6f1d359
Disable ASAssertLocked and ASAssertUnlocked (#1412)
nguyenhuy b0aabba
Try to remove global lock when initialising TextKit components (#1455)
zhongwuzw 68a16b2
Make ASCollectionNode's pan gesture customizable (#1457)
OskarZhang 601d4e2
Remove iOS 8 support from logging code. (#1462)
Adlai-Holler 46f0266
Drop support for Xcode 8 and fix some compiler warnings (#1463)
Adlai-Holler 1a7fdb8
Remove ASEventLog (#1460)
Adlai-Holler 7757a60
Cover the other background dealloc surfaces (#1464)
mikezucc 6346e49
Passthrough pagingEnabled for ASCollectionNode / ASTableNode (#1466)
maicki de7a206
Fix open context bug introduced in #1458 (#1468)
Adlai-Holler aee694b
Make sure all ASDisplayNode properties have backing ivars for consist…
5995708
Ensure ASControlMode properties lock before accessing their ivars (#1…
069f61b
Add a new "global drawing" experiment to use UIGraphicsRenderer (#1469)
Adlai-Holler 0ce0ad0
Cut version 2.8.1 (#1491)
nguyenhuy 3fe200f
Clean up documentation issues around periods (#1490)
amonshiz cdfa08f
Minor update in change log #changelog (#1492)
nguyenhuy d758fc7
Ship ASExperimentalFixRangeController (#1486)
nguyenhuy 3e4ab11
Shrink _ASCollectionPendingState from 144 to 128 bytes, a 12.5% reduc…
44117ea
Shrink _ASPendingState from 824 to 808 bytes, reduction of ~2% (#1483)
01208b7
Shrink ASDisplayNode from 1072 to 968 bytes, reduction of 10.74% (#1484)
8d0457c
Shrink Button Node (#1494)
ad6b6ab
Shrink TextNode(2) (#1495)
b6fedde
Shrink Pager and Scroll Node (#1496)
d2ffbc0
Shrink ASImageNode by .6% and ASNetworkImageNode by 2.2% (#1487)
d62967f
Remove unused declaration, missed in #1460 (#1497)
9eb4053
Keep the atomics - does not affect memory work (#1498)
b4ed8c9
Shrink ASCellNode by 8 bytes (#1499)
27ef809
Shrink ASEditableTextNode by 16 bytes (#1500)
8892800
ASSignpost: Add support for the os_signpost API, fixes (#1501)
Adlai-Holler 6329cf2
Shrink ASLayout (#1503)
a1b28e7
Cleanup whitespace #trivial (#1507)
wiseoldduck 79a9982
Shrink LayoutSpec classes (#1502)
1ffbc64
Merge branch 'master' of github.com:hebertialmeida/Texture
hebertialmeida 99e68a0
Merge remote-tracking branch 'upstream/master'
hebertialmeida 238d5ff
Merge branch 'master' into HAImproveIGListSupport
hebertialmeida File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, since we conform to
ASCollectionDelegateInterop
we should be already bridging these. See lines ~190 below, where we pass these calls directly through to the delegate.Can you put breakpoints in there or investigate why we're not seeing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I've checked that and it never fires the delegate because don't pass this checking:
Here: https://github.com/TextureGroup/Texture/blob/master/Source/ASCollectionView.mm#L1183
I am trying to understand the
shouldUseUIKitCell
and why do we need the check here to fire that.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I comment out this check it works, Also I noticed that this will be always
NO
and will never fire the delegate because it is a read-only property, it is only "YES" if it is anASWrapperCellNode
.Here it was checking:
Texture/Source/ASCollectionView.mm
Line 1100 in 550da24
It was first introduced here:
c6e3dd7#diff-8b82b1556d1293f6f9789beb236c9271R1167
Simplified here:
63efdbd#diff-8b82b1556d1293f6f9789beb236c9271R1169
For
ASWrapperCellNode
I have also found this:https://github.com/TextureGroup/Texture/blob/master/Source/ASCellNode.mm#L387-L393
and there is a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like @hebertialmeida is pointing out the problem, do this issue has any update?
Manual modifying ASIGListAdapterBasedDataSource.m isn't a nice solution for now as it is a private class. So it will be great if this issue get sort out and merge to master soon.
Thanks guys for the help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MiguelChiang Still waiting someone get back to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adlai-Holler can you please take a look when you get a chance?