[IGListKit] Adds missing UIScrollViewDelegate method to DataSource proxy #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds missing UIScrollViewDelegate method to IGListKit proxy
Adlai-Holler
approved these changes
Jul 9, 2018
maicki
approved these changes
Jul 9, 2018
There was a problem hiding this comment.
@wannabehero Great thanks for catching. Could you please add an entry into the CHANGELOG.md file, before we will merge into master.
|
@maicki updated thanks! |
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…oxy (TextureGroup#1015) * Adds missing UIScrollViewDelegate method to IGListKit proxy implementation * Updates CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
scrollViewDidEndDeceleratinghave been declared by proxy but wasn't not implemented, thus messages weren't delivered toIGListAdapter.scrollViewDelegate.This simple request addresses this issue.