Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricter locking assertions #1024

Merged

Commits on Jul 12, 2018

  1. Stricter locking assertions

    - Rename `ASDisplayNodeAssertLockUnownedByCurrentThread` to `ASDisplayNodeAssertLockNotHeld`, and `ASDisplayNodeAssertLockOwnedByCurrentThread` to `ASDisplayNodeAssertLockHeld` -> shorter and hopefully easier to distinguish between the two.
    - Add assertions to `_locked_` and `_u_` (i.e "unlocked") methods.
    - Turn `CHECK_LOCKING_SAFETY` flag on by default. After TextureGroup#1022 and TextureGroup#1023, we're in a good shape to actually enforce locked/unlocked requirements of internal methods. Our test suite passed, and we'll test more at Pinterest after the sync this week.
    - Fix ASVideoNode to avoid calling `play` while holding the lock. That method inserts a subnode and must be called lock free.
    - Other minor changes.
    nguyenhuy committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    c037799 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c2bdd1a View commit details
    Browse the repository at this point in the history
  3. Revert unnecessary change

    nguyenhuy committed Jul 12, 2018
    Configuration menu
    Copy the full SHA
    48b7fa1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b454388 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2018

  1. Use inline method

    nguyenhuy committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    49c21ae View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    372ff89 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0325062 View commit details
    Browse the repository at this point in the history
  4. Merge branch 'HN-Stricter-Locking-Safety-Checks' of github.com:nguyen…

    …huy/Texture into HN-Stricter-Locking-Safety-Checks
    nguyenhuy committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    4dd528f View commit details
    Browse the repository at this point in the history
  5. Simpler node loaded check: regardless of whether the node is view or …

    …layer backed, the layer should always be set if loaded
    nguyenhuy committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    f4234df View commit details
    Browse the repository at this point in the history