-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stricter locking assertions #1024
Merged
nguyenhuy
merged 9 commits into
TextureGroup:master
from
nguyenhuy:HN-Stricter-Locking-Safety-Checks
Jul 13, 2018
Merged
Stricter locking assertions #1024
nguyenhuy
merged 9 commits into
TextureGroup:master
from
nguyenhuy:HN-Stricter-Locking-Safety-Checks
Jul 13, 2018
Commits on Jul 12, 2018
-
- Rename `ASDisplayNodeAssertLockUnownedByCurrentThread` to `ASDisplayNodeAssertLockNotHeld`, and `ASDisplayNodeAssertLockOwnedByCurrentThread` to `ASDisplayNodeAssertLockHeld` -> shorter and hopefully easier to distinguish between the two. - Add assertions to `_locked_` and `_u_` (i.e "unlocked") methods. - Turn `CHECK_LOCKING_SAFETY` flag on by default. After TextureGroup#1022 and TextureGroup#1023, we're in a good shape to actually enforce locked/unlocked requirements of internal methods. Our test suite passed, and we'll test more at Pinterest after the sync this week. - Fix ASVideoNode to avoid calling `play` while holding the lock. That method inserts a subnode and must be called lock free. - Other minor changes.
Configuration menu - View commit details
-
Copy full SHA for c037799 - Browse repository at this point
Copy the full SHA c037799View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2bdd1a - Browse repository at this point
Copy the full SHA c2bdd1aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 48b7fa1 - Browse repository at this point
Copy the full SHA 48b7fa1View commit details -
Configuration menu - View commit details
-
Copy full SHA for b454388 - Browse repository at this point
Copy the full SHA b454388View commit details
Commits on Jul 13, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 49c21ae - Browse repository at this point
Copy the full SHA 49c21aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 372ff89 - Browse repository at this point
Copy the full SHA 372ff89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0325062 - Browse repository at this point
Copy the full SHA 0325062View commit details -
Merge branch 'HN-Stricter-Locking-Safety-Checks' of github.com:nguyen…
…huy/Texture into HN-Stricter-Locking-Safety-Checks
Configuration menu - View commit details
-
Copy full SHA for 4dd528f - Browse repository at this point
Copy the full SHA 4dd528fView commit details -
Simpler node loaded check: regardless of whether the node is view or …
…layer backed, the layer should always be set if loaded
Configuration menu - View commit details
-
Copy full SHA for f4234df - Browse repository at this point
Copy the full SHA f4234dfView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.