Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split framework dependencies into separate subspecs #1028

Merged
merged 2 commits into from
Jul 14, 2018
Merged

Split framework dependencies into separate subspecs #1028

merged 2 commits into from
Jul 14, 2018

Conversation

Adlai-Holler
Copy link
Member

@Adlai-Holler Adlai-Holler commented Jul 13, 2018 •
edited
Loading

  • Reduce binary size and dyld time.
  • Default cocoapods is the same (all + PINRemoteImage) for backwards compatibility.
    • Custom and Carthage build environments will break!! Consumers need to define AS_USE_MAPKIT, AS_USE_PHOTOS, AS_USE_ASSETS_LIBRARY to trigger their dep.
    • Not sure whether __has_include would work since system headers can always be reached if needed. Either way it's useful to trigger the integration with the system framework explicitly.
  • Standardize indentation in podspec.

cc @wiseoldduck @ay8s @garrettmoon @christianselig

Split framework dependencies into separate subspecs to reduce binary …
ae3a188 
…size and dynamic linking time when they're not needed
nguyenhuy
nguyenhuy approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

appleguy
appleguy approved these changes Jul 13, 2018
View reviewed changes
Copy link
Member

@appleguy appleguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

maicki
maicki approved these changes Jul 14, 2018
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Adlai-Holler Adlai-Holler merged commit 5cad23b into master Jul 14, 2018
@Adlai-Holler Adlai-Holler deleted the AHSplitDeps branch July 14, 2018 18:10
@Adlai-Holler Adlai-Holler mentioned this pull request Jul 17, 2018
Merged
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@Adlai-Holler @mikezucc
Split framework dependencies into separate subspecs to reduce binary …
b8a1fc1 
…size and dynamic linking time when they're not needed (TextureGroup#1028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@appleguy appleguy appleguy approved these changes

@nguyenhuy nguyenhuy nguyenhuy approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Adlai-Holler @maicki @appleguy @nguyenhuy