Create and set delegate for clip corner layers within ASDisplayNode #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
force-pushed
the
MSClipCornerLayersDelegate
branch
3 times, most recently
from
2adc7a8
to
8eeb5ba
Compare
|
🚫 CI failed with log |
|
@maicki Did you run the test suite locally? |
|
@nguyenhuy Yeah but I would rather wait for the CI to pass tbh |
|
👍 |
|
|
||
| - (id<CAAction>)actionForLayer:(CALayer *)layer forKey:(NSString *)event | ||
| { | ||
| return nil; |
There was a problem hiding this comment.
- Should we return
(id)kCFNullto prevent the default action, like we do for other layers? That suppresses the default action (e.g. fade in). - Is this different than setting no delegate on the layers?
- Let's share one single instance of this rather than creating one for each layer.
There was a problem hiding this comment.
- Yes this should return
(id)kCFNullI will change that. - Yes setting no delegate should animate the layer
- We are already sharing one instance if you look where we create the shared delegate for all of the corner layers within the code
|
🚫 CI failed with log |
Adlai-Holler
approved these changes
Jul 16, 2018
|
🚫 CI failed with log |
maicki
force-pushed
the
MSClipCornerLayersDelegate
branch
from
fca8083
to
5c2a135
Compare
|
🚫 CI failed with log |
|
🚫 CI failed with log |
Adlai-Holler
force-pushed
the
MSClipCornerLayersDelegate
branch
from
5c2a135
to
d66a4af
Compare
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…extureGroup#1029) * Create and use ASDisplayNodeCornerLayerDelegate * Return kCFNull for actionForLayer:forKey:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the delegate for all rounded corner layers are set to the owning display node. This has the effect that
actionForLayer:forKey:is called on the node for every corner layer although it should have their own delegate. InactionForLayer:forKey:we assert that the node is layer backed. This is not necessary needed if using corner rounding though.This diff will create an
ASDisplayNodeCornerLayerDelegateand set it as delegate for the corner layers.Fixes #1020, #910