Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NSMutableArray for retaining sublayout elements #1030

Merged
merged 5 commits into from
Jul 16, 2018
Merged

Remove NSMutableArray for retaining sublayout elements #1030

merged 5 commits into from
Jul 16, 2018

Conversation

Adlai-Holler
Copy link
Member

A little optimization.

@TextureGroup TextureGroup deleted a comment Jul 15, 2018
@TextureGroup TextureGroup deleted a comment Jul 15, 2018
@TextureGroup TextureGroup deleted a comment Jul 15, 2018
@TextureGroup TextureGroup deleted a comment Jul 15, 2018
@TextureGroup TextureGroup deleted a comment Jul 15, 2018
@Adlai-Holler
Copy link
Member Author

I give up on the CI.

appleguy
appleguy approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@appleguy appleguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - specifically because ASLayout is immutable, this should work.

@Adlai-Holler Adlai-Holler merged commit 0b9f127 into master Jul 16, 2018
@Adlai-Holler Adlai-Holler deleted the AHCheaperRetainSublayoutElements branch July 16, 2018 01:48
Adlai-Holler added a commit that referenced this pull request Jul 17, 2018
@Adlai-Holler
Fix the bug I introduced in #1030
f1cc314
@Adlai-Holler Adlai-Holler mentioned this pull request Jul 17, 2018
Merged
Adlai-Holler added a commit that referenced this pull request Jul 17, 2018
@Adlai-Holler
Fix the bug I introduced in #1030 (#1035)
cf810ac
@Adlai-Holler Adlai-Holler mentioned this pull request Jul 18, 2018
Merged
Adlai-Holler added a commit that referenced this pull request Jul 18, 2018
@Adlai-Holler
Revert unreleased layout debugging method name change from #1030 #tri…
9ade2b1 
…vial
Adlai-Holler added a commit that referenced this pull request Jul 18, 2018
@Adlai-Holler
Revert unreleased layout debug method name change from #1030 #trivial (…
db0f515 
…#1039)

* Revert unreleased layout debugging method name change from #1030 #trivial

* Eh make less changes
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@Adlai-Holler @mikezucc
Remove NSMutableArray for retaining sublayout elements (TextureGroup#…
fbd75e5 
…1030)

* Remove NSMutableArray for retaining sublayout elements

* Kick the CI

* Kick the CI again

* Smash that CI button

* Murder the CI
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@Adlai-Holler @mikezucc
Fix the bug I introduced in TextureGroup#1030 (TextureGroup#1035)
dc7a8e0
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@Adlai-Holler @mikezucc
Revert unreleased layout debug method name change from TextureGroup#1030
d4ab7ab 
 #trivial (TextureGroup#1039)

* Revert unreleased layout debugging method name change from TextureGroup#1030 #trivial

* Eh make less changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleguy appleguy appleguy approved these changes

@maicki maicki Awaiting requested review from maicki

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@nguyenhuy nguyenhuy Awaiting requested review from nguyenhuy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Adlai-Holler @appleguy