Turn off exceptions to reduce binary size (-600KB for arm64) #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
|
The CI is just plain broken =/ |
Adlai-Holler
commented
Jul 16, 2018
| @@ -30,7 +30,7 @@ | |||
| #define ASSetDebugName(node, format, ...) node.debugName = [NSString stringWithFormat:format, __VA_ARGS__] | |||
| #define ASSetDebugNames(...) _ASSetDebugNames(self.class, @"" # __VA_ARGS__, __VA_ARGS__, nil) | |||
| #else | |||
| #define ASSetDebugName(node, name) | |||
| #define ASSetDebugName(node, format, ...) | |||
There was a problem hiding this comment.
This was breaking release builds. I guess nobody uses this macro!!
appleguy
changed the title
maicki
approved these changes
Jul 16, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…Group#1033) * Turn off exceptions to reduce binary size * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't currently use exceptions so we don't need the extra binary to support them.
-fno-exceptionsremoves unwind tables and makes C++ STL put "abort" wherever there would be an exception.-fno-objc-arc-exceptionsremoves code that ARC adds to prevent leaks in the case of exceptions https://clang.llvm.org/docs/AutomaticReferenceCounting.html#exceptionsHow big is the win?
So modulo any Apple fiddling with your binary, the 64-bit one should shrink by about 600KB.