Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert unreleased layout debug method name change from #1030 #trivial #1039

Merged
merged 2 commits into from
Jul 18, 2018
Merged

Revert unreleased layout debug method name change from #1030 #trivial #1039

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ade2b1
Revert unreleased layout debugging method name change from #1030 #tri…
Adlai-Holler Jul 18, 2018
282162c
Eh make less changes
Adlai-Holler Jul 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions Source/Layout/ASLayout.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,11 @@ AS_EXTERN ASLayout *ASCalculateLayout(id<ASLayoutElement>layoutElement, const AS

/**
* Set to YES to tell all ASLayout instances to retain their sublayout elements. Defaults to NO.
* See `-retainSublayoutElements` to control this per-instance.
* See `-retainSublayoutLayoutElements` to control this per-instance.
*
* Note: Weaver relies on this API.
*/
@property (class) BOOL shouldRetainSublayoutElements;
@property (class) BOOL shouldRetainSublayoutLayoutElements;

/**
* Recrusively output the description of the layout tree.
Expand Down
3 changes: 0 additions & 3 deletions Source/Layout/ASLayout.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,6 @@ @interface ASLayout () <ASDescriptionProvider>
std::atomic_bool _retainSublayoutElements;
}

/// Call this to keep sublayout elements alive. Multiple calls have no effect.
- (void)retainSublayoutElements;

@property (nonatomic, readonly) ASRectMap *elementToRectMap;

@end
Expand Down