Avoid setting frame on a node's backing store while holding its lock #1048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing so may trigger `-layer:didChangeBoundsWithOldValue:newValue:` on the layer's delegate (i.e `ASCALayerExtendedDelegate`) which then runs other operations that require the lock to be free.
|
🚫 CI failed with log |
Generated by 🚫 Danger |
nguyenhuy
requested review from
Adlai-Holler,
maicki,
garrettmoon,
appleguy and
ay8s
maicki
reviewed
Jul 24, 2018
|
|
||
| if (setToView) { | ||
| ASDisplayNodeAssertTrue(nodeLoaded && isMainThread); | ||
| _view.frame = rect; |
There was a problem hiding this comment.
We may should grab the _view and _layer with the lock held?
There was a problem hiding this comment.
Those properties are only modified on main, and since this is on main thread, we can avoid locking.
There was a problem hiding this comment.
See also -isNodeLoaded.
maicki
approved these changes
Jul 24, 2018
nguyenhuy
added a commit
to nguyenhuy/Texture
that referenced
this pull request
Jul 24, 2018
…extureGroup#1048) Doing so may trigger `-layer:didChangeBoundsWithOldValue:newValue:` on the layer's delegate (i.e `ASCALayerExtendedDelegate`) which then runs other operations that require the lock to be free.
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…extureGroup#1048) Doing so may trigger `-layer:didChangeBoundsWithOldValue:newValue:` on the layer's delegate (i.e `ASCALayerExtendedDelegate`) which then runs other operations that require the lock to be free.
wiseoldduck
pushed a commit
to wiseoldduck/Texture
that referenced
this pull request
Jul 25, 2019
…'s lock (TextureGroup#1048)" This reverts commit 95de2ab.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing so may trigger
-layer:didChangeBoundsWithOldValue:newValue:on the layer's delegate (i.eASCALayerExtendedDelegate) which then runs other operations that require the lock to be free.