Readability improvements in ASDataController #trivial #1067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
commented
Aug 6, 2018
| ASCellNode *node = context.node; | ||
| if (node == nil) { | ||
| ASDisplayNodeAssertNotNil(node, @"Node block created nil node; %@, %@", self, strongDataSource); | ||
| node = [[ASCellNode alloc] init]; // Fallback to avoid crash for production apps. |
There was a problem hiding this comment.
I know this is scary, but the exact same assertion and side-path lives inside ASCollectionElement. That class never returns nil from node.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a new optional feature in data controller and it would be good to clear the deck before that patch.
Essentially the measurement pass is synchronous but it's treated as asynchronous. Patch that up. Also, ASCollectionElement never returns
nilfromnode, so remove that check and also some retain/releases.