Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#trivial Shouldn't hold the lock while adding subnodes #1091

Merged
merged 2 commits into from
Aug 31, 2018
Merged

#trivial Shouldn't hold the lock while adding subnodes #1091

merged 2 commits into from
Aug 31, 2018

Conversation

garrettmoon
Copy link
Member

Here's another one.

nguyenhuy
nguyenhuy requested changes Aug 30, 2018
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth adding a comment on why the macro isn’t sufficient?

@garrettmoon garrettmoon changed the title Shouldn't hold the lock while adding subnodes #trivial Shouldn't hold the lock while adding subnodes Aug 30, 2018
nguyenhuy
nguyenhuy approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@nguyenhuy nguyenhuy merged commit 1fe241d into master Aug 31, 2018
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@garrettmoon @mikezucc
#trivial Shouldn't hold the lock while adding subnodes (TextureGroup#…
8f890a1 
…1091)

* Shouldn't hold the lock while adding subnodes

* Add comments, good call @nguyenhuy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@garrettmoon @nguyenhuy