Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layer backed nodes not update properly #1110

Conversation

wsdwsd0829
Copy link
Contributor

No description provided.

@wsdwsd0829
Copy link
Contributor Author

Layers can be thrashed by UIKit with (exit then enter) during push/pop view controller or reload cells.
If exit & cancelAsyncDisplay, we are not showing the content if it's not nil.
More details are explained here: #1086

@ghost
Copy link

ghost commented Sep 11, 2018

🚫 CI failed with log

[self._locked_asyncLayer cancelAsyncDisplay];

// Don't call -didExitHierarchy while holding __instanceLock__.
// Don't call -didExitHierarchy while holding __instanceLock__.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add space to trigger CI

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems right! Later on, we should see if we can eliminate the "schedule display on enter hierarchy" behavior and make that rely on interface state too.

Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

@Adlai-Holler Adlai-Holler merged commit 1f0a213 into TextureGroup:master Sep 14, 2018
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449

* Fix to make rangeMode update in right time

* remove uncessary assert

* Fix collection cell editing bug for iOS 9 & 10

* Do not cancel on exit, interface state update should handle it.

* Revert "Fix collection cell editing bug for iOS 9 & 10"

This reverts commit 06e18a1.

* add space to trigger ci

* add change log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants