Remove use of NSHashTable for interface state delegates #trivial #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Adlai-Holler
commented
Sep 17, 2018
•
Adlai-Holler
commented
- An empty hash table takes 2 heap allocations at 288 bytes.
- 2 hash tables per node (original and copy for safe enumeration) is 576 bytes per node.
- ASDisplayNode is only 928 bytes, so these hash tables add 60% more weight.
- Most of these blocks are global blocks (no value capture, free retain/release) and some are stack blocks. No malloc blocks.
nguyenhuy
reviewed
Sep 17, 2018
| @@ -75,6 +75,7 @@ AS_EXTERN NSString * const ASRenderingEngineDidDisplayNodesScheduledBeforeTimest | |||
| #define TIME_DISPLAYNODE_OPS 0 // If you're using this information frequently, try: (DEBUG || PROFILE) | |||
|
|
|||
| #define NUM_CLIP_CORNER_LAYERS 4 | |||
| #define MAX_INTERFACE_STATE_DELEGATES 4 | |||
There was a problem hiding this comment.
Most nodes don't need more than 4 delegates, but there should be an API to increase it. That way users can do so without changing the framework.
nguyenhuy
approved these changes
Sep 17, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
…tureGroup#1122) * Remove use of NSHashTable for interface state delegates #trivial * Stray line * One more case * Add code to let people have more delegates * Do it more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.