Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ASRectMap, which is not worth its own weight #1127

Merged
merged 3 commits into from
Sep 18, 2018
Merged

Remove ASRectMap, which is not worth its own weight #1127

merged 3 commits into from
Sep 18, 2018

Conversation

Adlai-Holler
Copy link
Member

  • We create a lot of ASLayouts.
  • Each non-leaf one has an ASRectMap.
  • Two heap allocations per map (one for object, one for unordered_map's storage.)
  • Only used to make -frameForElement: faster.
  • Fast enumeration + direct ivar access is probably faster and saves us a ton of -init time.

nguyenhuy
nguyenhuy approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

maicki
maicki approved these changes Sep 18, 2018
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Adlai-Holler Adlai-Holler merged commit 69ed956 into master Sep 18, 2018
@Adlai-Holler Adlai-Holler deleted the AHRemoveRectMap branch September 18, 2018 18:58
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Oct 2, 2018
@Adlai-Holler @mikezucc
Remove ASRectMap, which is not worth its own weight (TextureGroup#1127)
6f3c57f
@stephensilber stephensilber mentioned this pull request Feb 15, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

@nguyenhuy nguyenhuy nguyenhuy approved these changes

@garrettmoon garrettmoon Awaiting requested review from garrettmoon

@appleguy appleguy Awaiting requested review from appleguy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Adlai-Holler @maicki @nguyenhuy