Fix compilation warnings #trivial #1132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
approved these changes
Sep 19, 2018
Source/ASDisplayNode.mm
Outdated
| @@ -80,6 +80,11 @@ @implementation ASDisplayNode | |||
|
|
|||
| static std::atomic_bool storesUnflattenedLayouts = ATOMIC_VAR_INIT(NO); | |||
|
|
|||
| - (ASDisplayNodeMethodOverrides)methodOverrides | |||
There was a problem hiding this comment.
I think we should put this method near other setters/getters (maybe here?). What do you think?
There was a problem hiding this comment.
Sounds good. It has been moved
added 4 commits
September 19, 2018 13:29
clang: warning: argument unused during compilation: '-fno-objc-arc-exceptions' [-Wunused-command-line-argument]
Instance method 'methodOverrides' in category from _ASDisplayView.o overrides method from class in ASDisplayNode.o
Adlai-Holler
approved these changes
Sep 20, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Oct 2, 2018
* Apply recommended warnings * Squelch designated initializer warning in ASViewController * Remove unused compiler flag clang: warning: argument unused during compilation: '-fno-objc-arc-exceptions' [-Wunused-command-line-argument] * Fix warning about overriding an instance variable within a category Instance method 'methodOverrides' in category from _ASDisplayView.o overrides method from class in ASDisplayNode.o
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses a number of warnings. No functional changes are intended.
clang: warning: argument unused during compilation: '-fno-objc-arc-exceptions' [-Wunused-command-line-argument]ASViewController.mm:40:23: Convenience initializer should not invoke an initializer on 'super'Instance method 'methodOverrides' in category from _ASDisplayView.o overrides method from class in ASDisplayNode.o