[ASTextNode2] Excluding origin from calculating text node size #1149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚫 CI failed with log |
Generated by 🚫 Danger |
ernestmama
changed the title
|
@Adlai-Holler Can you take a look at this PR when you have time? |
|
@ernestmama You're right that the problem is caused when ASTextLayout takes right/center/natural text alignment into account even when the max width is artifically large/inf. ASTextNode handles this correctly, but ASTextNode2 doesn't. However, I believe your fix can cause other problems, such as making ASTextNode2 to no longer correctly support these alignments. I proposed another fix (#1166) that is a bit more surgical and should work nicely with existing code, including ASTextLayout's cache. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASTextLayout would include the origin to the width, it does not work when the text node is layout with other layoutspec like StackLayout and when the container is provided with an ambiguous size.