Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ASTextNode2] Add improved support for all line-break modes in experimental text node. #1150

Merged
merged 3 commits into from
Oct 17, 2018

Commits on Sep 29, 2018

  1. ASTextNode2 rendering corrections.

    ASTextNode2 was only setting truncationMode (lineBreakMode) on existing paragraph styles in attributedString (thus having no effect for the two non-truncating modes if there were not any existing paragraph style runs).
    
    ASTextLayout (essentially YYTextLayout) was not rendering the two non-tail truncation lineBreakModes correctly. There's not much history on github but it appears to me that it was set up correctly at one time and then some additional code was added for unclear reasons that assumed any truncation was at the end of the string.
    
    This commit corrects both issues.
    wiseoldduck committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    9975c53 View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG.md

    wiseoldduck committed Sep 29, 2018
    Configuration menu
    Copy the full SHA
    9dba01b View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2018

  1. Configuration menu
    Copy the full SHA
    7641b76 View commit details
    Browse the repository at this point in the history