Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only clear ASCollectionView's data during deallocation #1154

Commits on Oct 1, 2018

  1. Only clear ASCollectionView's data during deallocation

    This is a follow up on TextureGroup#1136. Our experiment results show that clearing data frequently is the cause of our TextureGroup#1 crash. @maicki and I believe that this is because if the collection view is being used, silently clearing its data without notifying the backing UICollectionView can put it out-of-sync and causes mayhem next time the collection view processes a batch update. If you look at the stack trace closely, you'll notice that the crash doesn't occur on the same run loop that clearData is called. This made it extremely tricky to investigate and identify the root cause.
    
    Another interesting question would be whether or not we want to clear the data during deallocation at all, since the data will be cleared out soon anyway.
    nguyenhuy committed Oct 1, 2018
    Configuration menu
    Copy the full SHA
    93312f2 View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2018

  1. Fix experiment settings

    nguyenhuy committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    f07b8af View commit details
    Browse the repository at this point in the history
  2. Update CHANGELOG

    nguyenhuy committed Oct 2, 2018
    Configuration menu
    Copy the full SHA
    bf0a834 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2018

  1. Remove unnecessary changes

    nguyenhuy committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    fcdf287 View commit details
    Browse the repository at this point in the history
  2. Minor fix

    nguyenhuy committed Oct 3, 2018
    Configuration menu
    Copy the full SHA
    44a39d0 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4534451 View commit details
    Browse the repository at this point in the history