Mismatch name experimental features #1159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 06e18a1.
nguyenhuy
reviewed
Oct 3, 2018
Tests/ASConfigurationTests.m
Outdated
| @"exp_network_image_queue", | ||
| @"exp_collection_teardown", | ||
| @"exp_framesetter_cache", | ||
| @"exp_skip_clear_data"]; |
There was a problem hiding this comment.
Shouldn't this test include a bad name (e.g __invalid_name)?
wsdwsd0829
commented
Oct 3, 2018
| XCTAssertEqual(expected, ASExperimentalFeaturesFromArray(names)); | ||
| } | ||
|
|
||
| - (void)testFlagMatchName | ||
| { |
There was a problem hiding this comment.
to cover shift number must comes with names update cases.
Adlai-Holler
approved these changes
Oct 10, 2018
|
Looks good, could you add a changelog entry? |
…h-name-experimental-features
|
Done |
|
@garrettmoon @nguyenhuy Could you guys approve the build when you have a sec? |
|
🚫 CI failed with log |
nguyenhuy
approved these changes
Oct 10, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
* fix SIMULATE_WEB_RESPONSE not imported TextureGroup#449 * Fix to make rangeMode update in right time * remove uncessary assert * Fix collection cell editing bug for iOS 9 & 10 * Revert "Fix collection cell editing bug for iOS 9 & 10" This reverts commit 06e18a1. * fix mismatch of name array and experimental features * add more tests * remove nslog * add change log * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.