Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ASTextNode2 to ignore certain text alignments while calculating intrinsic size #1166

Merged

Commits on Oct 10, 2018

  1. Fix ASTextNode2 to ignore certain alignments while calculating intrin…

    …sic size
    
    ASTextNode2 uses ASTextLayout to calculate its layout and bounding rect. When the constrained width that is used for layout calculation is inf/max, ASTextLayout doesn't ignore right/center/natural text alignment but takes it into account. That results in an unreasonable size (and position).
    
    Fix by detecting when the node is calculating intrinsic size and force its layout alignment to be left. Other alignments should still work when the max width is finite/reasonable.
    nguyenhuy committed Oct 10, 2018
    Configuration menu
    Copy the full SHA
    a139d66 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2018

  1. Configuration menu
    Copy the full SHA
    2daeff6 View commit details
    Browse the repository at this point in the history
  2. Address Kevin's comments

    nguyenhuy committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    fbd6276 View commit details
    Browse the repository at this point in the history
  3. Tiny changes

    nguyenhuy committed Oct 11, 2018
    Configuration menu
    Copy the full SHA
    24365db View commit details
    Browse the repository at this point in the history