Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatch in UIAccessibilityAction selector method #1169

Merged
merged 2 commits into from
Oct 17, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Oct 12, 2018

A UIAccessibilityCustomAction can be initialized with a target and a selector. The selector is expecting methods with the following signature:

- (BOOL)performAccessibilityCustomAction;
- (BOOL)performAccessibilityCustomAction:(UIAccessibilityCustomAction *)action;

Within Texture we use a different signature:

- (void)performAccessibilityCustomAction:(UIAccessibilityCustomAction *)action;

This diff will update the Texture API to adapt the correct API for a UIAccessibilityCustomAction:

  • (BOOL)performAccessibilityCustomAction:(UIAccessibilityCustomAction *)action;

@maicki maicki merged commit 072df89 into master Oct 17, 2018
@maicki maicki deleted the MSFixAccessibilityActionMismatch branch October 17, 2018 16:45
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Nov 7, 2018
)

* Fix mismatch in UIAccessibilityAction selector method

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants