Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose test_resetWithConfiguration: for testing #trivial #1175

Merged
merged 1 commit into from
Oct 19, 2018

Conversation

maicki
Copy link
Contributor

@maicki maicki commented Oct 17, 2018

This makes it easier for conforming UI updates within tests.

Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer using the +test_resetWithConfiguration method to update configuration between unit tests (setUp or tearDown).

@maicki maicki changed the title Add interface coalescing disable API #trivial Expose test_resetWithConfiguration: for testing #trivial Oct 17, 2018
@maicki
Copy link
Contributor Author

maicki commented Oct 17, 2018

@Adlai-Holler Ok let's go a different route. We have to expose +test_resetWithConfiguration otherwise you have to expose it somehow within the tests.

This makes it easier to write tests for specific configurations.
@maicki maicki merged commit 2f3c0b4 into master Oct 19, 2018
@maicki maicki deleted the MSAddDisableRunLoopQueue branch October 27, 2018 00:21
mikezucc pushed a commit to mikezucc/Texture that referenced this pull request Nov 7, 2018
…p#1175)

This makes it easier to write tests for specific configurations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants