Expose a way to determine if a text node will truncate for a given constrained size #trivial #1177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Adlai-Holler It's not due to performance, it's due to the reference of Removed commented out code. |
Adlai-Holler
approved these changes
Oct 17, 2018
maicki
force-pushed
the
MSTextNodeAdditions
branch
2 times, most recently
from
547a716
to
01f83a0
Compare
maicki
changed the title
|
🚫 CI failed with log |
maicki
force-pushed
the
MSTextNodeAdditions
branch
from
8275ef4
to
9535aa9
Compare
- Expose textLayoutForConstraint:, but make unavailable on ASTextNode - Refactor compatibleLayoutWithContainer:text: into a static method
…edSize: in ASTextNode
maicki
force-pushed
the
MSTextNodeAdditions
branch
from
9535aa9
to
14a905c
Compare
|
🚫 CI failed with log |
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
…nstrained size #trivial (TextureGroup#1177) * Expose textLayoutForConstraint: - Expose textLayoutForConstraint:, but make unavailable on ASTextNode - Refactor compatibleLayoutWithContainer:text: into a static method * Instead of textLayoutForConstraint: expose shouldTruncateForConstrainedSize: in ASTextNode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ASTextNodefor nowcompatibleLayoutWithContainer:text:into a static method