Newline character support and truncated line sizing improvement. #1193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For purposes of truncating text, respect explicit newlines. Don't size to smaller than truncated line width unless we have to.
maicki
approved these changes
Oct 30, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
…tureGroup#1193) * Newline character support and truncated line sizing improvement. For purposes of truncating text, respect explicit newlines. Don't size to smaller than truncated line width unless we have to. * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we use the returned size for sizeThatFits, we need to make sure we don't truncate text and then return the smaller size (leading to even more text being truncated).
If a newline character takes the text outside of the bounds, that text should be truncated.