ASTextNode2 to consider both width and height when determining if it is calculating an intrinsic size #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is calculating an instrinsic size
Generated by 🚫 Danger |
maicki
reviewed
Oct 30, 2018
There was a problem hiding this comment.
LGTM, would have another look from @nguyenhuy or @Adlai-Holler though.
Also, @ernestmama could we add a test for this scenario and add an entry to the changelog. Thanks!
nguyenhuy
approved these changes
Nov 1, 2018
|
Adding a change log entry isn't required because it'd be the same with the one added for #1166. |
nguyenhuy
pushed a commit
that referenced
this pull request
Nov 1, 2018
…is calculating an instrinsic size (#1196)
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
…is calculating an instrinsic size (TextureGroup#1196)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was only considering the individual constraint width/height when calculating the intrinsic size. However, this will not work when textnode is in a vertical ASStackLayoutSpec which also try to set a flexShrink.
If it needs to calculate either height or width based on its own content where either of them is ambiguous, it needs to apply the proper line break mode and text alignment.
Related commit: a139d66