Add experiment flag to skip layoutIfNeeded in enterPreloadState for ASM nodes #trivial #1201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adlai-Holler
approved these changes
Oct 30, 2018
maicki
force-pushed
the
MSSkipLayoutInEnteringPreloadExperiment
branch
2 times, most recently
from
1fb9590
to
bc7354d
Compare
nguyenhuy
approved these changes
Nov 2, 2018
maicki
force-pushed
the
MSSkipLayoutInEnteringPreloadExperiment
branch
from
bc7354d
to
d762711
Compare
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performing a layout pass within
didEnterPreloadStatecan have a meaningful performance impact, enough that we should measure it as an ASConfiguration experimental feature.