Revert #1023 #trivial #1204
Merged
Revert #1023 #trivial #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
force-pushed
the
MSRevert#1023
branch
2 times, most recently
from
ea29eee
to
1c7da5d
Compare
nguyenhuy
approved these changes
Nov 1, 2018
mikezucc
pushed a commit
to mikezucc/Texture
that referenced
this pull request
Nov 7, 2018
We will revert TextureGroup#1023. The current solution introduces problems if we are unlocking before calling _completePendingLayoutTransition. _completePendingLayoutTransition needs to be happening in one transaction if called from _u_measureNodeWithBoundsIfNecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will revert #1023 until we find a different solution for the underlying issue.
The current solution introduces problems if we are unlocking before calling
_completePendingLayoutTransitionin_u_measureNodeWithBoundsIfNecessary._completePendingLayoutTransitionneeds to be happening in one transaction if called from_u_measureNodeWithBoundsIfNecessary.Unfortunately this also means we need to remove some of our locking assertions within subnodes insertion / removal methods.