Fix A11Y for horizontal collection nodes in Texture #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collections have their own handling in UIKit that we shouldn't mess with. As such no nodes that contain CollectionNodes should ever be treated as AccessibilityContainers.
Adlai-Holler
approved these changes
Nov 6, 2018
nguyenhuy
reviewed
Nov 6, 2018
| #pragma mark - Accessibility overrides | ||
|
|
||
| - (NSArray *)accessibilityElements { | ||
| [self waitUntilAllUpdatesAreCommitted]; |
There was a problem hiding this comment.
I’m not familiar with accessbility and not sure when this method is called, but are you sure we want to block the (main?) thread in this case? Would it be better to somehow trigger an accessibility elements recollection once the table/collection finishes its updates?
nguyenhuy
added a commit
to nguyenhuy/Texture
that referenced
this pull request
Jan 11, 2019
…view are committed in -accessibilityElements The wait was introduced in TextureGroup#1217 which blocks the main thread until updates are proccessed. We suspect this causes perf regressions accross the app and need to confirm this via an experiment.
nguyenhuy
added a commit
that referenced
this pull request
Jan 11, 2019
…view are committed in -accessibilityElements The wait was introduced in #1217 which blocks the main thread until updates are proccessed. We suspect this causes perf regressions accross the app and need to confirm this via an experiment.
nguyenhuy
added a commit
that referenced
this pull request
Jan 24, 2019
…iews under some circumstances (#1311) * Add experiment to skip waiting until all updates of collection/table view are committed in -accessibilityElements The wait was introduced in #1217 which blocks the main thread until updates are proccessed. We suspect this causes perf regressions accross the app and need to confirm this via an experiment. * Add option to skip default behavior of ASCellLayoutMode * Fix unit test * Fix unit test in another way * Remove import * Minor change * Add ASCellLayoutModeSyncForSmallContent * Update unit tests * Remove unnecessary change * Remove unnecessary changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Collections have their own handling in UIKit that we shouldn't mess with. As such no nodes that contain CollectionNodes should ever be treated as AccessibilityContainers.