Use interface state to manage image loading in ASMultiplexImageNode #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to 1172 but for ASMultiplexImageNode
appleguy
approved these changes
Nov 27, 2018
|
@nguyenhuy I wonder if we should flush the pending interface state here? It seems like in some cases like a displayIfNeeded / recursivelyEnsureDisplay preparing for an animation, skipping this call or flush could lead to the cache not being checked. Feel free to land if you're confident, just wanted to share the possibility of edge cases with interface state coalescing or even standard -displayIfNeeded without the interfaceState fully set. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to #1172 but for ASMultiplexImageNode