[ASPrimitiveTraitCollection] Fix ASPrimitiveTraitCollectionMakeDefault and implement containerSize #1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t and implement containerSize With the changes to `ASPrimitiveTraitCollection` in TextureGroup@e392f83 a new `ASPrimitiveTraitCollectionMakeDefault` was created. The new method didn’t give all values in an `ASPrimitiveTraitCollection` a default value (or initialize the struct with `{}`). This was causing fields like `userInterfaceIdiom`, `forceTouchCapability`, and `displayScale` to be filled with garbage, leading to `ASPrimitiveTraitCollectionIsEqualToASPrimitiveTraitCollection` to return `YES` when the trait collection hadn’t really changed. It also looks like the getter `containerSize` was not implemented.
rcancro
changed the title
nguyenhuy
approved these changes
Nov 28, 2018
Adlai-Holler
approved these changes
Nov 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the changes to
ASPrimitiveTraitCollectionin e392f83 a newASPrimitiveTraitCollectionMakeDefaultwas created. The new method didn’t give all values in anASPrimitiveTraitCollectiona default value (or initialize the struct with{}). This was causing fields likeuserInterfaceIdiom,forceTouchCapability, anddisplayScaleto be filled with garbage, leading toASPrimitiveTraitCollectionIsEqualToASPrimitiveTraitCollectionto returnYESwhen the trait collection hadn’t really changed.It also looks like the getter
containerSizewas not implemented.