Forwards cell's hitTest:withEvent and pointInside:withEvent calls to node. #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Adlai-Holler
approved these changes
Nov 28, 2018
maicki
approved these changes
Nov 28, 2018
Co-Authored-By: stremsdoerfer <[email protected]>
Formatting Co-Authored-By: stremsdoerfer <[email protected]>
|
Replaced by #1268 . Thanks @stremsdoerfer for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unlike ASDisplayView, ASCollectionView doesn't redirect its hitTest:withEvent and pointInside:withEvent calls to its node. As a result, if a cell has a node that has a hitTestSlop that goes beyond the cell bounds it will be ignored.
This PR fixes that issue by forwarding the cell hitTest and pointInside calls to the node.