Disable a11y cache #1274
Merged
Disable a11y cache #1274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
approved these changes
Dec 7, 2018
|
|
||
| @interface ASDisplayViewAccessibilityTests : XCTestCase | ||
| @end | ||
|
|
||
| @implementation ASDisplayViewAccessibilityTests | ||
|
|
||
| - (void)setUp { |
There was a problem hiding this comment.
Bracket on the following line please.
| NSArray<UIAccessibilityElement *> *updatedElements2 = contianer.view.accessibilityElements; | ||
| XCTAssertTrue([[updatedElements2.firstObject accessibilityLabel] isEqualToString:@"hello, world, !!!!"]); | ||
| } | ||
| - (void)testAccessibilityNonLayerbackedNodesOperationInContainer { |
There was a problem hiding this comment.
Same here. Also separate these methods by new lines.
wsdwsd0829
added a commit
to wsdwsd0829/Texture
that referenced
this pull request
Mar 14, 2019
* disable a11y cache * style update
wsdwsd0829
added a commit
to wsdwsd0829/Texture
that referenced
this pull request
Mar 15, 2019
* disable a11y cache * style update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable because a11y not update correctly as layer backed nodes inserted/removed/updated.
A few other case will fail otherwise as shown in tests.
Fixes: #1161
Attempt to invalidate a11y (instead of disable cache) code is here: #1260 while does not seem worth the effort.