Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove UIKit header import in AsyncTransaction file #1275

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Remove UIKit header import in AsyncTransaction file #1275

merged 1 commit into from
Dec 17, 2018

Conversation

zhongwuzw
Copy link
Contributor

We don't need import whole UIApplication header file only for UITrackingRunLoopMode. We can just extern it instead.

@CLAassistant
Copy link

CLAassistant commented Dec 9, 2018 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

maicki
maicki approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhongwuzw Thanks for improving!

@maicki maicki merged commit 351e402 into TextureGroup:master Dec 17, 2018
@zhongwuzw zhongwuzw deleted the remove_UIKit_import branch December 20, 2018 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maicki maicki maicki approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhongwuzw @CLAassistant @maicki