Allow truncation mode (head/tail/middle) for attribute string #1287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is the commit which added support for the truncation: #1150 |
|
@wiseoldduck What do you think? It seems like your previous commit fix the truncation problem. Is it safe to remove the switch? |
|
I do not believe it is. The ASTextLayout class uses the "inner" mode to break up the lines, and then applies the "real" mode to the final line. |
|
From @wiseoldduck's comment, it seems like we should close this issue. Feel free to reopen it. Thanks all. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Truncation mode (Head/Tail/Middle) override has not been applied when preparing for attributed string. It was default to WordWrapping. Those truncation mode is currently rendering correctly. This change is to let the override happens for all lineBreakMode.