Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce startup time. #1292

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Reduce startup time. #1292

merged 1 commit into from
Jan 15, 2019

Conversation

dmaclach
Copy link
Contributor

Move file scope constant that is initialized at startup to function scope to avoid startup hit.

@ghost
Copy link

ghost commented Dec 19, 2018

🚫 CI failed with log

@maicki
Copy link
Contributor

maicki commented Dec 21, 2018

The CI failure is not due to changes in this PR. @dmaclach would you mind to rebase from master to restart the CI. Thanks!

Copy link
Contributor

@maicki maicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me

Source/ASDisplayNode.mm Outdated Show resolved Hide resolved
Move file scope constant that is initialized at startup to function scope to avoid startup hit.
@dmaclach
Copy link
Contributor Author

Can somebody merge?

@maicki maicki merged commit e59eff8 into TextureGroup:master Jan 15, 2019
@dmaclach dmaclach deleted the static1 branch January 15, 2019 17:14
@dmaclach
Copy link
Contributor Author

Thank you kindly!

raviTokopedia pushed a commit to raviTokopedia/Texture that referenced this pull request Mar 5, 2020
Move file scope constant that is initialized at startup to function scope to avoid startup hit.

(cherry picked from commit e59eff8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants