Reduce startup time. #1293
Merged
Reduce startup time. #1293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maicki
reviewed
Dec 22, 2018
| - (void)setAsyncdisplaykit_context:(ASBasicImageDownloaderContext *)asyncdisplaykit_context | ||
| { | ||
| objc_setAssociatedObject(self, kContextKey, asyncdisplaykit_context, OBJC_ASSOCIATION_RETAIN_NONATOMIC); | ||
| objc_setAssociatedObject(self, ContextKey(), asyncdisplaykit_context, OBJC_ASSOCIATION_RETAIN_NONATOMIC); |
There was a problem hiding this comment.
I would suggest instead of using a static const let's use the selector instead:
objc_setAssociatedObject(self, @selector(asyncdisplaykit_context), asyncdisplaykit_context, OBJC_ASSOCIATION_RETAIN_NONATOMIC);
There was a problem hiding this comment.
Done.. I kept the function just because I felt it better documented what we were doing with the Selector.
Move file level static into a function so that it isn't being initialized pre-main.
|
ping? |
raviTokopedia
pushed a commit
to raviTokopedia/Texture
that referenced
this pull request
Mar 5, 2020
Move file level static into a function so that it isn't being initialized pre-main. (cherry picked from commit 0a48cd7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move file level static into a function so that it isn't being initialized pre-main.