Remove let and var macros now that we're all-C++ #1312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
approved these changes
Jan 11, 2019
nguyenhuy
reviewed
Jan 11, 2019
| @@ -1551,7 +1551,7 @@ - (BOOL)collectionView:(UICollectionView *)collectionView canMoveItemAtIndexPath | |||
| return NO; | |||
| } | |||
|
|
|||
| // If the data source implements canMoveItem, const auto them decide. | |||
| // If the data source implements canMoveItem, let them decide. | |||
There was a problem hiding this comment.
“constant auto them decide” makes a good joke though lol
|
Could someone const auto @garrettmoon know the CI is in trouble? |
|
Done. Might take until early next week for him/Ricky to kick the machine though. |
maicki
approved these changes
Jan 13, 2019
|
🚫 CI failed with log |
Adlai-Holler
force-pushed
the
AHRemoveLetVar
branch
from
a10bfbc
to
227a5a1
Compare
|
🚫 CI failed with log |
|
🚫 CI failed with log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not only are these a little icky but the label "var" is used in Abseil header functions which causes it to choke when imported after Texture.