-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental features (exp_skip_a11y_wait && exp_new_default_cell_layout_mode) #1383
Changes from all commits
2813f6c
42ef59f
d4afe22
504e7e4
df53269
0e84fc0
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1703,20 +1703,18 @@ - (BOOL)dataControllerShouldSerializeNodeCreation:(ASDataController *)dataContro | |
|
||
- (BOOL)dataController:(ASDataController *)dataController shouldSynchronouslyProcessChangeSet:(_ASHierarchyChangeSet *)changeSet | ||
{ | ||
if (ASActivateExperimentalFeature(ASExperimentalNewDefaultCellLayoutMode)) { | ||
// Reload data is expensive, don't block main while doing so. | ||
if (changeSet.includesReloadData) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any reason we removed this if clause? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This code was not there when the new layout changes was introduced. This is added when we created the experiment afterward. I checked with @nguyenhuy that we did not experiment without this block of code. I will put it back. |
||
return NO; | ||
} | ||
// For more details on this method, see the comment in the ASCollectionView implementation. | ||
if (changeSet.countForAsyncLayout < 2) { | ||
return YES; | ||
} | ||
CGSize contentSize = self.contentSize; | ||
CGSize boundsSize = self.bounds.size; | ||
if (contentSize.height <= boundsSize.height && contentSize.width <= boundsSize.width) { | ||
return YES; | ||
} | ||
// Reload data is expensive, don't block main while doing so. | ||
if (changeSet.includesReloadData) { | ||
return NO; | ||
} | ||
// For more details on this method, see the comment in the ASCollectionView implementation. | ||
if (changeSet.countForAsyncLayout < 2) { | ||
return YES; | ||
} | ||
CGSize contentSize = self.contentSize; | ||
CGSize boundsSize = self.bounds.size; | ||
if (contentSize.height <= boundsSize.height && contentSize.width <= boundsSize.width) { | ||
return YES; | ||
} | ||
return NO; | ||
} | ||
|
@@ -2036,9 +2034,7 @@ - (void)didMoveToSuperview | |
|
||
- (NSArray *)accessibilityElements | ||
{ | ||
if (!ASActivateExperimentalFeature(ASExperimentalSkipAccessibilityWait)) { | ||
[self waitUntilAllUpdatesAreCommitted]; | ||
} | ||
[self waitUntilAllUpdatesAreCommitted]; | ||
return [super accessibilityElements]; | ||
} | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason we removed this if clause?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code was not there when the new layout changes was introduced. This is added when we created the experiment afterward. I checked with @nguyenhuy that we did not experiment without this block of code. I will put it back.