Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NetworkingImageNode: update URL if we found image in assets #1473

Merged
merged 2 commits into from
Jun 7, 2019
Merged

NetworkingImageNode: update URL if we found image in assets #1473

merged 2 commits into from
Jun 7, 2019

Conversation

zhongwuzw
Copy link
Contributor

If we find image in bundle assets, we also need to update URL to try to load animated image.

Adlai-Holler
Adlai-Holler reviewed Jun 4, 2019
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EDIT: nm

Adlai-Holler
Adlai-Holler approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@Adlai-Holler Adlai-Holler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be worth a comment above the new line, saying // Update URL to point to newly-resolved file URL for animated image load.

@zhongwuzw
Copy link
Contributor Author

@Adlai-Holler Done :)

nguyenhuy
nguyenhuy approved these changes Jun 7, 2019
View reviewed changes
Copy link
Member

@nguyenhuy nguyenhuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nguyenhuy nguyenhuy merged commit 1cb2334 into TextureGroup:master Jun 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nguyenhuy nguyenhuy nguyenhuy approved these changes

@Adlai-Holler Adlai-Holler Adlai-Holler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhongwuzw @nguyenhuy @Adlai-Holler